Re: [PR] [FLINK-25421] Add JdbcSink with new format [flink-connector-jdbc]

2024-01-04 Thread via GitHub
RocMarshal commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1441443240 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/sink/JdbcSinkBuilder.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-25421] Add JdbcSink with new format [flink-connector-jdbc]

2024-01-03 Thread via GitHub
MartijnVisser commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1875367844 @wanglijie95 Do you have bandwidth to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [FLINK-25421] Add JdbcSink with new format [flink-connector-jdbc]

2023-11-23 Thread via GitHub
eskabetxe commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1824762588 @wanglijie95 , @snuyanzin could you check please.. The sink in this moment allows non-xa (at least once) and xa (exactly once) connections I need to add documentati