1996fanrui merged PR #24881:
URL: https://github.com/apache/flink/pull/24881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on PR #24881:
URL: https://github.com/apache/flink/pull/24881#issuecomment-2164197766
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui commented on code in PR #24881:
URL: https://github.com/apache/flink/pull/24881#discussion_r1636152962
##
flink-core/src/test/java/org/apache/flink/core/fs/InitOutputPathTest.java:
##
@@ -23,59 +23,52 @@
import org.apache.flink.core.fs.local.LocalFileSystem;
import
1996fanrui commented on PR #24881:
URL: https://github.com/apache/flink/pull/24881#issuecomment-2161888308
> Thanks @GOODBOY008 for the quick update, LGTM now. Hi @1996fanrui, could
you help double check this PR?
Thank @Jiabao-Sun for the ping, I will check it these 2 days.
--
Jiabao-Sun commented on code in PR #24881:
URL: https://github.com/apache/flink/pull/24881#discussion_r1626824660
##
flink-core/src/test/java/org/apache/flink/core/fs/AutoCloseableRegistryTest.java:
##
@@ -66,9 +64,9 @@ public void testSuppressedExceptions() throws Exception {
flinkbot commented on PR #24881:
URL: https://github.com/apache/flink/pull/24881#issuecomment-2145361395
## CI report:
* c1b3b0623e1d0fd68ca0d10924cea9bfa693b368 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
GOODBOY008 opened a new pull request, #24881:
URL: https://github.com/apache/flink/pull/24881
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
GOODBOY008 closed pull request #24685: [FLINK-25537] [JUnit5 Migration] Module:
flink-core with,Package: core
URL: https://github.com/apache/flink/pull/24685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
1996fanrui commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2144183912
> @flinkbot run azure
Hi @GOODBOY008 , the CI cannot be triggered for this PR. Creating a new PR
may be a workaround for it.
--
This is an automated message from the Apache
GOODBOY008 commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2143263153
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
GOODBOY008 commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2141075315
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
GOODBOY008 commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2140991378
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1996fanrui commented on code in PR #24685:
URL: https://github.com/apache/flink/pull/24685#discussion_r1597784913
##
flink-core/src/test/java/org/apache/flink/core/memory/CrossSegmentTypeTest.java:
##
@@ -86,15 +84,15 @@ private void testCompare(MemorySegment seg1,
1996fanrui commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2105650954
> @1996fanrui PTAL
Thanks @GOODBOY008 for the ping, this PR is huge, I try to review it next
week.
--
This is an automated message from the Apache Git Service.
To respond to
GOODBOY008 commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2105650442
@1996fanrui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
GOODBOY008 commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2066192460
@Jiabao-Sun @1996fanrui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
flinkbot commented on PR #24685:
URL: https://github.com/apache/flink/pull/24685#issuecomment-2066063146
## CI report:
* 2b1bc24cbfb7a12d0741a34caae26bd52ad195f5 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
GOODBOY008 opened a new pull request, #24685:
URL: https://github.com/apache/flink/pull/24685
changes:
- Migrate module core to junit5 with core package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
18 matches
Mail list logo
