Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-11 Thread via GitHub
mxm commented on code in PR #23887: URL: https://github.com/apache/flink/pull/23887#discussion_r1422202775 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/TimestampColumnReader.java: ## @@ -109,6 +157,37 @@ public static TimestampData

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-08 Thread via GitHub
tweise merged PR #23887: URL: https://github.com/apache/flink/pull/23887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-08 Thread via GitHub
tweise commented on code in PR #23887: URL: https://github.com/apache/flink/pull/23887#discussion_r1420897743 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/TimestampColumnReader.java: ## @@ -109,6 +157,37 @@ public static TimestampDa

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-07 Thread via GitHub
mxm commented on code in PR #23887: URL: https://github.com/apache/flink/pull/23887#discussion_r1419139910 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/vector/reader/TimestampColumnReader.java: ## @@ -109,6 +157,37 @@ public static TimestampData

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-07 Thread via GitHub
tweise commented on PR #23887: URL: https://github.com/apache/flink/pull/23887#issuecomment-1845429843 @MartijnVisser good point - strictly speaking it is a bug, let me add a comment to the ticket. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
MartijnVisser commented on PR #23887: URL: https://github.com/apache/flink/pull/23887#issuecomment-1844815550 @tweise Was this a bug? If so, we should change the type of ticket. Don't forget to add 1.18.1 as a fix version then as well. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
flinkbot commented on PR #23887: URL: https://github.com/apache/flink/pull/23887#issuecomment-1843686785 ## CI report: * a7c97714166fa29046b174a0d014f9f1bdb69843 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
tweise opened a new pull request, #23887: URL: https://github.com/apache/flink/pull/23887 backport #18304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
tweise merged PR #18304: URL: https://github.com/apache/flink/pull/18304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1843660558 Also verified with my application. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1842179446 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1842032773 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1842026548 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1841996519 @cuibo01 thanks, I resolved conflicts and pushed the merge for testing - will do a rebase after we see tests pass. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
cuibo01 commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1841927134 @tweise , Of course you can, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1841618310 @cuibo01 @MartijnVisser I just run into this issue (Flink 1.17) and was happy to find this PR. Any reason this stalled? Can I help get this to the finish line? -- This is an automated m