kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2085392466
@ferenc-csaky Thank you for reviewing my PR and for your helpful feedback! I
really appreciate your support in improving it.
--
This is an automated message from the Apache Git
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2084837876
This is fixed now as well, see new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1581270742
##
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSRecoverableFsDataOutputStreamTest.java:
##
@@ -133,57 +131,57 @@ public void
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2079230716
Sorry for the delay on my end, I added a new commit to address all your
comments above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1543181369
##
flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/GSFileSystemScenarioTest.java:
##
@@ -148,31 +147,31 @@ public void simpleWriteTest()
kottmann commented on PR #22789:
URL: https://github.com/apache/flink/pull/22789#issuecomment-2010479115
@ferenc-csaky Thank you for your insightful feedback and for directing me
towards the assertj decision. I updated my branch by rebasing it onto master
and incorporating the changes
ferenc-csaky commented on code in PR #22789:
URL: https://github.com/apache/flink/pull/22789#discussion_r1511222835
##
flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopFreeTests.java:
##
Review Comment:
Use AssertJ's
