Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1771603366 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/DispatcherResourceCleanerFactory.java: ## @@ -124,10 +127,39 @@ JOB_MANAGER_METRIC

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1771349785 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/LocallyCleanableInMainThreadResource.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache S

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1771347067 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/cleanup/TestingResourceCleanerFactory.java: ## @@ -26,27 +26,42 @@ import java.util.ArrayList; import

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1771279162 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/OnMainThreadJobManagerRunnerRegistry.java: ## @@ -84,9 +84,10 @@ public Collection getJobM

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1771276366 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/LocallyCleanableInMainThreadResource.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1771262937 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/cleanup/TestingResourceCleanerFactory.java: ## @@ -26,27 +26,42 @@ import java.util.Array

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1703278478 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/TestingJobManagerRunnerRegistry.java: ## @@ -188,11 +197,26 @@ public static class Builder { p

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1741038687 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java: ## @@ -369,7 +377,9 @@ private MiniDispatcher createMiniDispatche

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1741026602 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -83,9 +83,16 @@ public Collection getJobManage

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1703145088 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/cleanup/LocallyCleanableInMainThreadResource.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache S

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on PR #25027: URL: https://github.com/apache/flink/pull/25027#issuecomment-2261137905 @XComp , could you please take another look. I'll work on figuring out the following meanwhile: > I'm wondering whether you could come up with a test where we verify that th

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on PR #25027: URL: https://github.com/apache/flink/pull/25027#issuecomment-2261134869 > The test `testJobSubmissionUnderSameJobId` fails with this change because we it expects the unregistration to be completed before the `JobManagerRunner` is terminated. Need t

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on PR #25027: URL: https://github.com/apache/flink/pull/25027#issuecomment-2260921569 The test `testJobSubmissionUnderSameJobId` fails with this change because we it expects the unregistration to be completed before the `JobManagerRunner` is terminated. Need to

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1692705494 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -83,9 +83,15 @@ public Collection getJobManagerRunners() {

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1692695511 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -83,9 +83,15 @@ public Collection getJobManage

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1692695511 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -83,9 +83,15 @@ public Collection getJobManage

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1687470490 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -83,9 +83,15 @@ public Collection getJobManagerRunners() {

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1686805757 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1686804638 ## flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistryTest.java: ## @@ -164,7 +164,8 @@ void testFailingLocalClea

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1686721979 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1686411653 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unregister(JobID j

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1685926520 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1683903323 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unregister(JobID j

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1683288457 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1682297518 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unregister(JobID j

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1681117423 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1681117423 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1681117423 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1681117423 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1681117423 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1681117423 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1681117423 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1681117423 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unreg

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1680520986 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -97,6 +106,14 @@ public JobManagerRunner unregister(JobID j

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1679615203 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -41,10 +42,12 @@ public class DefaultJobManag

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on PR #25027: URL: https://github.com/apache/flink/pull/25027#issuecomment-2231141258 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1679572415 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManage

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1673562535 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManagerRunners() {

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1673394381 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManage

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668650443 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManagerRunners() {

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668650443 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManagerRunners() {

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

kumar-mallikarjuna commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668545338 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManage

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668120064 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManagerRunners() {