Re: [PR] [FLINK-28513] Fix Flink Table API CSV streaming sink throws SerializedThrowable exception [flink]

2024-01-02 Thread via GitHub
hlteoh37 commented on PR #21458: URL: https://github.com/apache/flink/pull/21458#issuecomment-1873903855 Thanks for flagging @MartijnVisser. I'd agree that it would be good to update tests to reflect this discovered bug in the Filesystem S3 integration. I had forgotten that we have a test

Re: [PR] [FLINK-28513] Fix Flink Table API CSV streaming sink throws SerializedThrowable exception [flink]

2023-12-28 Thread via GitHub
MartijnVisser commented on PR #21458: URL: https://github.com/apache/flink/pull/21458#issuecomment-1871208283 In hindsight I'm quite concerned that we have merged this without any change to the tests. We run nightly tests for the FileSink and StreamingFileSink against S3. Why have those