[PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2023-12-15 Thread via GitHub
afedulov opened a new pull request, #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735 This PR contains the following improvements to the restart tracking logic: * Adds more debug logs * Stores restart Duration directly instead of the endTime Instant * Fixes a bu

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2023-12-18 Thread via GitHub
mxm commented on code in PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#discussion_r1429815765 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -182,22 +182,22 @@ private void runScalingLogic(Context ctx, A

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2023-12-18 Thread via GitHub
mxm commented on code in PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#discussion_r1429815765 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -182,22 +182,22 @@ private void runScalingLogic(Context ctx, A

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2023-12-18 Thread via GitHub
mxm commented on PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#issuecomment-1859964401 This needs a rebase. I'll run the tests afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2023-12-19 Thread via GitHub
gyfora commented on code in PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#discussion_r1431637325 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -182,22 +182,22 @@ private void runScalingLogic(Context ctx,

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2023-12-19 Thread via GitHub
gyfora commented on code in PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#discussion_r1431638371 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -182,22 +182,22 @@ private void runScalingLogic(Context ctx,

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2023-12-19 Thread via GitHub
mxm commented on code in PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#discussion_r1431686776 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -182,22 +182,22 @@ private void runScalingLogic(Context ctx, A

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2024-01-09 Thread via GitHub
afedulov commented on code in PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#discussion_r1446480705 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -182,22 +182,22 @@ private void runScalingLogic(Context ct

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2024-01-09 Thread via GitHub
afedulov commented on PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#issuecomment-1883606900 @mxm I addressed the comments and rebased, could you please kick off the tests again? -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2024-01-09 Thread via GitHub
mxm commented on PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#issuecomment-1883609244 Sure, they should be running now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2024-01-10 Thread via GitHub
mxm merged PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] [FLINK-30593][autoscaler] Improve restart time tracking [flink-kubernetes-operator]

2024-01-10 Thread via GitHub
afedulov commented on PR #735: URL: https://github.com/apache/flink-kubernetes-operator/pull/735#issuecomment-1884713935 @mxm @gyfora Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to