gyfora commented on PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1932314211
> My understanding is that in the main Flink project people are encouraged
to use the Jira Release Note field in case something special needs to be
mentioned for the respe
afedulov commented on PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1932291404
My understanding is that in the main Flink project people are encouraged to
use the Jira Release Note field in case something special needs to be mentioned
for the respe
gyfora commented on PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1932109209
> Should we capture a deprecation warning for future releases in the Release
Note for this ticket or do we track such things elsewhere for the operator
project?
We
afedulov commented on PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1932092848
Should we capture a deprecation warning for future releases in the Release
Note for this ticket or do we track such things elsewhere for the operator
project?
--
This
gyfora merged PR #770:
URL: https://github.com/apache/flink-kubernetes-operator/pull/770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
gyfora commented on PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1929184152
Added some comments @afedulov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
afedulov commented on code in PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#discussion_r1478491551
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/ReflectiveDiffBuilder.java:
##
@@ -172,4 +173,26 @@ pr
gyfora commented on PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1927221588
> Hi @gyfora , thanks for addressing this issue! Overall looks good to me,
just some minor things to clarify (see comments). Also, is my understanding
correct that the CRD
gyfora commented on code in PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#discussion_r1478404649
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/ReflectiveDiffBuilder.java:
##
@@ -172,4 +173,26 @@ priv
gyfora commented on code in PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#discussion_r1478403482
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/ReflectiveDiffBuilder.java:
##
@@ -172,4 +173,26 @@ priv
afedulov commented on code in PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#discussion_r1478361632
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/ReflectiveDiffBuilder.java:
##
@@ -172,4 +173,26 @@ pr
afedulov commented on PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1927206600
Hi @gyfora , thanks for addressing this issue! Overall looks good to me,
just some minor things to clarify (see comments). Also, my is my understanding
right that the CR
gyfora commented on PR #770:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1921435716
cc @afedulov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gyfora opened a new pull request, #770:
URL: https://github.com/apache/flink-kubernetes-operator/pull/770
## What is the purpose of the change
The PodTemplate fields in the CRD currently incorrectly use the Pod time,
when they should be PodTemplateSpec type. This leads to unnecessary
14 matches
Mail list logo
