Re: [PR] [FLINK-32894] Use 3.3.0 for maven-shade-plugin to support Java 17 [flink-connector-shared-utils]

2023-12-06 Thread via GitHub
PatrickRen commented on PR #20: URL: https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1844516188 @snuyanzin @echauchot Thanks for the review! I bumped the version to 3.5.1 as suggested. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-32894] Use 3.3.0 for maven-shade-plugin to support Java 17 [flink-connector-shared-utils]

2023-12-05 Thread via GitHub
snuyanzin commented on PR #20: URL: https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1840937326 yep sure @PatrickRen would you mind to bump it to 3.5.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-32894] Use 3.3.0 for maven-shade-plugin to support Java 17 [flink-connector-shared-utils]

2023-12-05 Thread via GitHub
echauchot commented on PR #20: URL: https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1840799581 @snuyanzin as you already started, do you want to take this review ? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [FLINK-32894] Use 3.3.0 for maven-shade-plugin to support Java 17 [flink-connector-shared-utils]

2023-11-07 Thread via GitHub
snuyanzin commented on PR #20: URL: https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1799805561 does it make sense to bump to 3.5.1 since there was added support for jdk20+ ? https://issues.apache.org/jira/browse/MSHADE-454 -- This is an automated message