[PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-04 Thread via GitHub
JingGe opened a new pull request, #23870: URL: https://github.com/apache/flink/pull/23870 ## What is the purpose of the change CollectSinkFunction$ServerThread uses configured port ## Brief change log - Add new TaskManagerOptions#COLLECT_PORT - CollectSink

Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-14 Thread via GitHub
xintongsong commented on code in PR #23870: URL: https://github.com/apache/flink/pull/23870#discussion_r1427504078 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -173,6 +173,18 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-15 Thread via GitHub
JingGe commented on PR #23870: URL: https://github.com/apache/flink/pull/23870#issuecomment-1857569661 Thanks @xintongsong for your review and comments. I have addressed all of them. Once you confirmed the PR, I will rebase it and squash all commits into one. -- This is an automated m

Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-15 Thread via GitHub
JingGe commented on PR #23870: URL: https://github.com/apache/flink/pull/23870#issuecomment-1858528411 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-18 Thread via GitHub
JingGe merged PR #23870: URL: https://github.com/apache/flink/pull/23870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-32949][core]collect tm port binding with TaskManagerOptions [flink]

2023-12-04 Thread via GitHub
flinkbot commented on PR #23870: URL: https://github.com/apache/flink/pull/23870#issuecomment-1839718853 ## CI report: * bafa44ff546c1b700477451f19e6bf924ac1d8ec UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`