vtkhanh opened a new pull request, #105:
URL: https://github.com/apache/flink-connector-aws/pull/105
## Purpose of the change
Allow a table can be used as a source and sink when it's defined with both
consumer & producer options. The ability is achieved by not verifying an opt
boring-cyborg[bot] commented on PR #105:
URL:
https://github.com/apache/flink-connector-aws/pull/105#issuecomment-1763380621
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is a
vahmed-hamdy commented on PR #105:
URL:
https://github.com/apache/flink-connector-aws/pull/105#issuecomment-1763895230
Hi @vtkhanh, Could you please describe the use case more. It feels like an
anti-pattern to use the same stream as source and sink. Kinesis Table API
source and sink imple
dannycranmer commented on PR #105:
URL:
https://github.com/apache/flink-connector-aws/pull/105#issuecomment-1763968191
> Kinesis Table API source and sink implementations were intentionally
separated post 1.15.
No we kept them together, and supported the legacy configs for backwards
dannycranmer commented on PR #105:
URL:
https://github.com/apache/flink-connector-aws/pull/105#issuecomment-1764006877
Actions are failing due to a recent bug, will fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vtkhanh commented on PR #105:
URL:
https://github.com/apache/flink-connector-aws/pull/105#issuecomment-1764481474
> Hi @vtkhanh, Could you please describe the use case more. It feels like an
anti-pattern to use the same stream as source and sink. Kinesis Table API
source and sink implement
vtkhanh commented on PR #105:
URL:
https://github.com/apache/flink-connector-aws/pull/105#issuecomment-1764483073
> Actions are failing due to a recent bug, will fix
Merged your fix and updated the PR. Thanks for looking @dannycranmer.
--
This is an automated message from the Apach
dannycranmer merged PR #105:
URL: https://github.com/apache/flink-connector-aws/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
boring-cyborg[bot] commented on PR #105:
URL:
https://github.com/apache/flink-connector-aws/pull/105#issuecomment-1770659259
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
