Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
MartijnVisser merged PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356731370 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -40,18 +40,15 @@ import org.apache.flink.typ

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
MartijnVisser commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356673406 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -40,18 +40,15 @@ import org.apache.flink

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356612136 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -40,18 +40,15 @@ import org.apache.flink.typ

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356612136 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -40,18 +40,15 @@ import org.apache.flink.typ

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
ferenc-csaky commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356603415 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSo

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
ferenc-csaky commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356603415 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSo

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356589772 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356589772 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
ferenc-csaky commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356574049 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSo

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
ferenc-csaky commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356575876 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/source/HBaseRowDataAsyncLookupFunctionTest.java: ## @@ -74,8 +72,8 @@ publi

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356564633 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356560575 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356563142 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -469,11 +470,13 @@ private void verifyHBaseLo

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356560575 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

[PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
MartijnVisser opened a new pull request, #27: URL: https://github.com/apache/flink-connector-hbase/pull/27 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u