[PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

pvary opened a new pull request, #23912: URL: https://github.com/apache/flink/pull/23912 ## What is the purpose of the change Mixin based implementation for [FLIP-372](https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+a

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

pvary commented on PR #23912: URL: https://github.com/apache/flink/pull/23912#issuecomment-1864763831 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

leonardBang commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1433677957 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/TwoPhaseCommittingSink.java: ## @@ -40,17 +37,9 @@ * @param The type of the committables. */

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

pvary commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1433804590 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/TwoPhaseCommittingSink.java: ## @@ -40,17 +37,9 @@ * @param The type of the committables. */ @Publi

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

leonardBang commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1433838959 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/TwoPhaseCommittingSink.java: ## @@ -40,17 +37,9 @@ * @param The type of the committables. */

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445462324 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/Sink.java: ## @@ -52,11 +54,30 @@ public interface Sink extends Serializable { * @param contex

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445463214 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/StatefulSink.java: ## @@ -36,49 +34,43 @@ * @param The type of the sink writer's state */ @Pub

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445465244 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/SupportsWriterState.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445464969 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/SupportsWriterState.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

rodmeneses commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1445467435 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/WithPreWriteTopology.java: ## @@ -21,18 +21,9 @@ import org.apache.flink.annota

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

pvary commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1446081006 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/Sink.java: ## @@ -52,11 +54,30 @@ public interface Sink extends Serializable { * @param context the

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

pvary commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1446081187 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/StatefulSink.java: ## @@ -36,49 +34,43 @@ * @param The type of the sink writer's state */ @PublicEv

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

pvary commented on code in PR #23912: URL: https://github.com/apache/flink/pull/23912#discussion_r1446081742 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/connector/sink2/WithPreWriteTopology.java: ## @@ -21,18 +21,9 @@ import org.apache.flink.annotation.

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

pvary commented on PR #23912: URL: https://github.com/apache/flink/pull/23912#issuecomment-1883046267 Thanks @rodmeneses for the review! The PR will merged in several parts, to help the reviewers. The first part is #24022, addressed your comments there. -- This is an automated messag

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

pvary closed pull request #23912: [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach URL: https://github.com/apache/flink/pull/23912 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

pvary commented on PR #23912: URL: https://github.com/apache/flink/pull/23912#issuecomment-1908498601 We merged this in several smaller parts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-33328] Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable - mixin approach [flink]

flinkbot commented on PR #23912: URL: https://github.com/apache/flink/pull/23912#issuecomment-1852213829 ## CI report: * 64b7d707433f11bb4e1636796fb4c290376ac9cf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`