Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2024-03-06 Thread via GitHub
ferenc-csaky commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1981649671 > @ferenc-csaky Will you rebase this PR? I'll close #39 Yes, will do. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2024-03-06 Thread via GitHub
ferenc-csaky opened a new pull request, #35: URL: https://github.com/apache/flink-connector-hbase/pull/35 cc @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2024-03-06 Thread via GitHub
MartijnVisser commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1981591807 @ferenc-csaky Will you rebase this PR? I'll close https://github.com/apache/flink-connector-hbase/pull/39 -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2024-03-06 Thread via GitHub
MartijnVisser closed pull request #35: [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows URL: https://github.com/apache/flink-connector-hbase/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2024-01-30 Thread via GitHub
ferenc-csaky commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1916952587 @MartijnVisser pinning the older Guava also works, AFAIK externalized connectors are not necessary to depend on the `flink-shaded` Guava. I am pro removing HBase 1

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2024-01-16 Thread via GitHub
ferenc-csaky commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1893935504 > We need to decide how to resolve the Guava dependency convergence: we can't pin the latest version, since that misses classes that are required by HBase. Perhaps we

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2023-12-28 Thread via GitHub
MartijnVisser commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1871254126 We need to decide how to resolve the Guava dependency convergence: we can't pin the latest version, since that misses classes that are required by HBase. Perhaps we

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2023-12-21 Thread via GitHub
snuyanzin commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1867027544 There was snappy update, probably need to add explicit dependency to cope with

Re: [PR] [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [flink-connector-hbase]

2023-12-20 Thread via GitHub
ferenc-csaky commented on PR #35: URL: https://github.com/apache/flink-connector-hbase/pull/35#issuecomment-1865506167 cc @MartijnVisser @snuyanzin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go