[PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-03 Thread via GitHub
leoyy0316 opened a new pull request, #23656: URL: https://github.com/apache/flink/pull/23656 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-12-13 Thread via GitHub
xuyangzhong commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1855089363 Hi, @leoyy0316 and @MartijnVisser . Let's talk in the jira instead of this pr. I shared my view there. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-03 Thread via GitHub
flinkbot commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1792360510 ## CI report: * 31d5c1e7a3896f8b5958dc56486f510c9bfdd263 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-03 Thread via GitHub
leoyy0316 commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1792384316 > I'm not sure that we want to support this function (I have no strong opinion there, but I don't see this in other technologies like Hive or Spark). However, without tests, this PR sho

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-03 Thread via GitHub
MartijnVisser commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1792398513 > we need use this function, so can we suuport this function? That's not something that we should decide over a PR, but before opening a Jira ticket and a PR should be brought

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-04 Thread via GitHub
leoyy0316 commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1793390742 > > I'm not sure that we want to support this function (I have no strong opinion there, but I don't see this in other technologies like Hive or Spark). However, without tests, this PR s

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-10 Thread via GitHub
MartijnVisser commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1805286458 > trino support this function, we need use this function, so can we suuport this function? I don't think Trino is the primary engine we compare ourselves against. Does the eq

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-10 Thread via GitHub
leoyy0316 commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1805324411 > > trino support this function, we need use this function, so can we suuport this function? > > I don't think Trino is the primary engine we compare ourselves against. Does the

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-10 Thread via GitHub
MartijnVisser commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1805337202 > I have a question, why we always follow hive and spark? if we thinks is a feature need to support, we can implement it firstly. i think having rich functions is better Beca

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-11-12 Thread via GitHub
leoyy0316 commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1807423595 > > I have a question, why we always follow hive and spark? if we thinks is a feature need to support, we can implement it firstly. i think having rich functions is better > > Be