[PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-11-07 Thread via GitHub
bvarghese1 opened a new pull request, #23681: URL: https://github.com/apache/flink/pull/23681 ## What is the purpose of the change Implement restore tests for GroupAggregate node ## Verifying this change This change added tests and can be verified as follows:

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-11-07 Thread via GitHub
flinkbot commented on PR #23681: URL: https://github.com/apache/flink/pull/23681#issuecomment-1800844592 ## CI report: * 7d14168f580690f52bafea6e5be95c2d31f30525 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-05 Thread via GitHub
jnh5y commented on PR #23681: URL: https://github.com/apache/flink/pull/23681#issuecomment-1840907198 The CI failure is from spotless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-06 Thread via GitHub
dawidwys commented on code in PR #23681: URL: https://github.com/apache/flink/pull/23681#discussion_r1417001274 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -133,6 +134,12 @@ public Builder consumedAfterRestore(Ro

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-06 Thread via GitHub
bvarghese1 commented on code in PR #23681: URL: https://github.com/apache/flink/pull/23681#discussion_r1418419627 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -133,6 +134,12 @@ public Builder consumedAfterRestore(

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-06 Thread via GitHub
bvarghese1 commented on code in PR #23681: URL: https://github.com/apache/flink/pull/23681#discussion_r1418420396 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/GroupAggregateTestPrograms.java: ## @@ -0,0 +1,367 @@ +/* + *

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-06 Thread via GitHub
bvarghese1 commented on code in PR #23681: URL: https://github.com/apache/flink/pull/23681#discussion_r1418421096 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -109,7 +109,8 @@ public EnumSet

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-06 Thread via GitHub
bvarghese1 commented on code in PR #23681: URL: https://github.com/apache/flink/pull/23681#discussion_r1418421435 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -109,7 +109,8 @@ public EnumSet

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-07 Thread via GitHub
dawidwys merged PR #23681: URL: https://github.com/apache/flink/pull/23681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac