Re: [PR] [FLINK-33563] Implement type inference for Agg functions [flink]

2023-11-16 Thread via GitHub
dawidwys merged PR #23724: URL: https://github.com/apache/flink/pull/23724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-33563] Implement type inference for Agg functions [flink]

2023-11-16 Thread via GitHub
liuyongvs commented on PR #23724: URL: https://github.com/apache/flink/pull/23724#issuecomment-1814219168 LGTM + 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [FLINK-33563] Implement type inference for Agg functions [flink]

2023-11-16 Thread via GitHub
liuyongvs commented on code in PR #23724: URL: https://github.com/apache/flink/pull/23724#discussion_r1395522133 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CollectTypeStrategy.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to th

Re: [PR] [FLINK-33563] Implement type inference for Agg functions [flink]

2023-11-16 Thread via GitHub
dawidwys commented on code in PR #23724: URL: https://github.com/apache/flink/pull/23724#discussion_r1395496582 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CollectTypeStrategy.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33563] Implement type inference for Agg functions [flink]

2023-11-15 Thread via GitHub
liuyongvs commented on code in PR #23724: URL: https://github.com/apache/flink/pull/23724#discussion_r1395071815 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CollectTypeStrategy.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to th

Re: [PR] [FLINK-33563] Implement type inference for Agg functions [flink]

2023-11-15 Thread via GitHub
flinkbot commented on PR #23724: URL: https://github.com/apache/flink/pull/23724#issuecomment-1812725651 ## CI report: * c994854e5d4f385d5f455c6bd3d61fea00220238 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33563] Implement type inference for Agg functions [flink]

2023-11-15 Thread via GitHub
dawidwys opened a new pull request, #23724: URL: https://github.com/apache/flink/pull/23724 ## What is the purpose of the change Implement type inference for `DISTINCT` and `COLLECT` ## Verifying this change Added tests for `COLLECT` output type strategy ## Does this p