Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1857456731
Thanks @snuyanzin, it makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1857452824
ArchUnit does not suport scala, it is mentioned in readme
snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1855611405
@XComp , @Jiabao-Sun
it seems current build failure is related
could you please have a look
https://github.com/apache/flink/pull/23929
--
This is an automated message from
XComp commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1855535740
Sounds reasonable. Can you create a follow-up ticket for that one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1855510460
Thanks @XComp, the ArchUnit's rules require the `MiniclusteExtension`
declared as `static final`, but in scala, we can only declare it `private val`
in `object`, but this cannot be
XComp merged PR #23914:
URL: https://github.com/apache/flink/pull/23914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1854769170
@Jiabao-Sun
>I tend to avoid too much CI failure through this PR until we find the root
cause.
>WDYT 樂️
I put commit with WA I've described above at
snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853781175
I tested with junit5.10.1 and I think it also introduced some changes
if you look at PR https://github.com/apache/flink/pull/23917 where there is
only junit bump 5.9.1 -> 5.10.1
Jiabao-Sun commented on code in PR #23914:
URL: https://github.com/apache/flink/pull/23914#discussion_r1425242859
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/utils/StreamAbstractTestBase.java:
##
@@ -22,10 +22,14 @@
import
Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853767448
Hi @snuyanzin, I think the `SnapshotDirectory.cleanup` may not be the root
cause.
I debugged it locally, and the directory structure cleared by
SnapshotDirectory is start with
snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853578934
> That would mean that we should wait for the snapshot cleanup to finish
before calling @AfterEach-annotated methods, wouldn't it?
ideally yes
--
This is an automated message
Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853575930
Thanks @snuyanzin @XComp, I'll try to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
XComp commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853573483
Thanks for this finding, @snuyanzin . That would mean that we should wait
for the snapshot cleanup to finish before calling `@AfterEach`-annotated
methods, wouldn't it?
--
This is an
snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853554316
@Jiabao-Sun , @XComp
it seems I found the reason
junit5.10.1 makes it always failing and it is becoming a bit more clear
there are 2 threads
1. junit5 trying to
XComp commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853544386
> The var tempFolder: Path = _ defines in scala is an object field already,
for each @Test method, it is different.
Thanks for clarification. My lack of Scala knowledge made me mix
Jiabao-Sun commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853193955
Thanks @XComp, @snuyanzin.
The comments were addressed and print the files that are not deleted when
IOException throws.
> StreamingTestBase#tempFolder is a class field which
snuyanzin commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1853037273
@Jiabao-Sun I would suggest to update JUnit
https://github.com/apache/flink/pull/23917
where they improved logging for `Tempdir` removal
at
XComp commented on code in PR #23914:
URL: https://github.com/apache/flink/pull/23914#discussion_r1424283608
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/utils/StreamAbstractTestBase.java:
##
@@ -22,10 +22,14 @@
import
flinkbot commented on PR #23914:
URL: https://github.com/apache/flink/pull/23914#issuecomment-1852331226
## CI report:
* 9de6704a23d33a78b3b8b7d94f59355f3335064e UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Jiabao-Sun opened a new pull request, #23914:
URL: https://github.com/apache/flink/pull/23914
## What is the purpose of the change
[FLINK-33641][test] Suppress the DirectoryNotEmptyException in
StreamingWithStateTestBase to prevent test failures
## Brief change log
20 matches
Mail list logo
