pnowojski commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1450048228
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java:
##
@@ -41,8 +43,14 @@
/** He
pnowojski merged PR #24023:
URL: https://github.com/apache/flink/pull/24023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apa
StefanRRichter commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1448868567
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java:
##
@@ -41,8 +43,14 @@
/
pnowojski commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1448861339
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloader.java:
##
@@ -41,8 +43,14 @@
/** He
pnowojski commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1448857937
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/MemoryStateBackend.java:
##
@@ -65,8 +54,8 @@
*
* {@code
* StreamExecutionEnvir
StefanRRichter commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1448564562
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/MemoryStateBackend.java:
##
@@ -65,8 +54,8 @@
*
* {@code
* StreamExecution
dawidwys commented on PR #24023:
URL: https://github.com/apache/flink/pull/24023#issuecomment-1886664226
I think that's a fair approach. I agree very few users implement state
backends and if they do they are knowledgeable enough to easily migrate their
code. Moreover we changed this interf
pnowojski commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1447579407
##
flink-end-to-end-tests/flink-stream-state-ttl-test/src/main/java/org/apache/flink/streaming/tests/StubStateBackend.java:
##
@@ -58,42 +46,16 @@ final class StubSta
pnowojski commented on PR #24023:
URL: https://github.com/apache/flink/pull/24023#issuecomment-1883070789
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pnowojski commented on PR #24023:
URL: https://github.com/apache/flink/pull/24023#issuecomment-1883070691
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
pnowojski commented on PR #24023:
URL: https://github.com/apache/flink/pull/24023#issuecomment-1877155133
Thanks for the review!
> Why only add the download metric? While you are at this, you could have
also simply added metrics for, e.g., merge/clip.
That was the scope of the
pnowojski commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1441789636
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackendParametersImpl.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Found
StefanRRichter commented on code in PR #24023:
URL: https://github.com/apache/flink/pull/24023#discussion_r1440607428
##
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackendParametersImpl.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software
flinkbot commented on PR #24023:
URL: https://github.com/apache/flink/pull/24023#issuecomment-1875528953
## CI report:
* e7b15627f0fe1823eb893fff103e8c0f715bc223 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
pnowojski opened a new pull request, #24023:
URL: https://github.com/apache/flink/pull/24023
This PR builds on top of https://github.com/apache/flink/pull/23908
## Brief change log
Please check individual commit messages
## Verifying this change
This change has bee
15 matches
Mail list logo
