liuyongvs opened a new pull request, #23898:
URL: https://github.com/apache/flink/pull/23898
## What is the purpose of the change
*The PR is about to replace deprecated
StreamTableEnvironment#toRetractDataStream with
StreamTableEnvironment#toChangelogStream as mentioned in ja
xuyangzhong commented on code in PR #23898:
URL: https://github.com/apache/flink/pull/23898#discussion_r1427704155
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/RowToTuple2.scala:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Softwar
snuyanzin commented on PR #23898:
URL: https://github.com/apache/flink/pull/23898#issuecomment-1899850866
@liuyongvs are you going to continuwe working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
flinkbot commented on PR #23898:
URL: https://github.com/apache/flink/pull/23898#issuecomment-1846938906
## CI report:
* 8ca93097658734c4e971050970795567430f04df UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
liuyongvs commented on PR #23898:
URL: https://github.com/apache/flink/pull/23898#issuecomment-1849337372
hi @snuyanzin @dawidwys could you help review this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
liuyongvs commented on PR #23898:
URL: https://github.com/apache/flink/pull/23898#issuecomment-1849837960
> Thanks for the contribution
>
> 1. can you please fix PR description accordingly?
> 2. it seems the PR does not clean up all usages (at least in planner),
however it should
liuyongvs commented on PR #23898:
URL: https://github.com/apache/flink/pull/23898#issuecomment-1849863462
@snuyanzin thanks very much, I didn't notice that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
liuyongvs commented on PR #23898:
URL: https://github.com/apache/flink/pull/23898#issuecomment-1849866511
@snuyanzin and do you also help reveiw this cleanup?
https://github.com/apache/flink/pull/23897
https://github.com/apache/flink/pull/23895
https://github.com/apache/flink/pull/23
