xintongsong closed pull request #24163: [FLINK-33728] Do not rewatch when
KubernetesResourceManagerDriver wat…
URL: https://github.com/apache/flink/pull/24163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zhougit86 commented on PR #24163:
URL: https://github.com/apache/flink/pull/24163#issuecomment-1956068736
> @zhougit86,
>
> Thanks for addressing my comments. The PR LGTM.
>
> The CI failures seem unrelated to this PR. I have just rebased the PR onto
the latest master branch. L
xintongsong commented on code in PR #24163:
URL: https://github.com/apache/flink/pull/24163#discussion_r1496940478
##
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java:
##
@@ -90,7 +92,7 @@ public class KubernetesResourceManagerDrive
zhougit86 commented on PR #24163:
URL: https://github.com/apache/flink/pull/24163#issuecomment-1954032190
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zhougit86 commented on code in PR #24163:
URL: https://github.com/apache/flink/pull/24163#discussion_r1495227606
##
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java:
##
@@ -114,7 +116,8 @@ public KubernetesResourceManagerDriver(
xintongsong commented on code in PR #24163:
URL: https://github.com/apache/flink/pull/24163#discussion_r1494040971
##
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java:
##
@@ -412,11 +415,9 @@ private void stopPod(String podName) {
xintongsong commented on PR #24163:
URL: https://github.com/apache/flink/pull/24163#issuecomment-1914013482
@zhougit86 ,
If you need any help in understanding the comments, feel free to reach out
to my email (tonysong...@gmail.com). We may exchange WeChat ID and have an
offline phone cal
xintongsong commented on code in PR #24163:
URL: https://github.com/apache/flink/pull/24163#discussion_r1469101401
##
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClientTest.java:
##
@@ -454,6 +451,22 @@ void testWatchPodsAndDoCallback()
zhougit86 commented on PR #24163:
URL: https://github.com/apache/flink/pull/24163#issuecomment-1913601244
@xintongsong Hi , I got a chance to modify my commit, would you please
bother to review for another time?
--
This is an automated message from the Apache Git Service.
To respond to th
xintongsong commented on code in PR #24163:
URL: https://github.com/apache/flink/pull/24163#discussion_r1462693554
##
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java:
##
@@ -102,6 +109,14 @@ public Fabric8FlinkKubeClient(
zhougit86 commented on PR #24163:
URL: https://github.com/apache/flink/pull/24163#issuecomment-1903769843
@xintongsong Would you please take a look and let me know your thinking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
flinkbot commented on PR #24163:
URL: https://github.com/apache/flink/pull/24163#issuecomment-1903516752
## CI report:
* 67741049ceefd714af4f21588c63d222104a9e88 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
zhougit86 opened a new pull request, #24163:
URL: https://github.com/apache/flink/pull/24163
…ch fail
## What is the purpose of the change
prevent jm restart in case kubernetes fails to handle watch request
## Brief change log
use ExponentialBackoffRetr
13 matches
Mail list logo
