Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-18 Thread via GitHub
HuangXingBo merged PR #23894: URL: https://github.com/apache/flink/pull/23894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-18 Thread via GitHub
liuyongvs commented on PR #23894: URL: https://github.com/apache/flink/pull/23894#issuecomment-1860241060 > LTGM. BTW, should we also update this function in pyflink? cc @HuangXingBo Further more, please modify the description of this pr. the python code of has no use, we do not

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-15 Thread via GitHub
liuyongvs commented on PR #23894: URL: https://github.com/apache/flink/pull/23894#issuecomment-1857586748 @xuyangzhong thanks for your review and fix the description of pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-13 Thread via GitHub
liuyongvs commented on PR #23894: URL: https://github.com/apache/flink/pull/23894#issuecomment-1854976683 hi @lsyldliu @xuyangzhong will you also help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-10 Thread via GitHub
liuyongvs commented on PR #23894: URL: https://github.com/apache/flink/pull/23894#issuecomment-1849338235 hi @snuyanzin @dawidwys could you help review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-08 Thread via GitHub
flinkbot commented on PR #23894: URL: https://github.com/apache/flink/pull/23894#issuecomment-1846727842 ## CI report: * 4b38e0f7e69cc63a7977745e702a6e797e19a5ea UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-07 Thread via GitHub
liuyongvs opened a new pull request, #23894: URL: https://github.com/apache/flink/pull/23894 …tateRetentionTime ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we