Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-12 Thread via GitHub
snuyanzin merged PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
snuyanzin commented on PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#issuecomment-1850502662 @pvary yep, sure here it is a link https://github.com/snuyanzin/flink-connector-kafka/actions/runs/7170817788 sorry I didn't put earlier -- This is an auto

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
pvary commented on PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#issuecomment-1850450046 @snuyanzin: Do we have a PR where this job has been tried out, and working? For testing my changes I started using the changes on my own repo to verify that everything is

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
snuyanzin commented on code in PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#discussion_r1422535978 ## .github/workflows/python_ci.yml: ## @@ -23,6 +23,11 @@ on: description: "Flink version to test against." required: true

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
pvary commented on code in PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#discussion_r1422406134 ## .github/workflows/python_ci.yml: ## @@ -23,6 +23,11 @@ on: description: "Flink version to test against." required: true ty

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
pvary commented on code in PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#discussion_r1422406134 ## .github/workflows/python_ci.yml: ## @@ -23,6 +23,11 @@ on: description: "Flink version to test against." required: true ty

Re: [PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
snuyanzin commented on PR #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30#issuecomment-1849915282 @gaborgsomogyi , @dianfu since you had a look at smilar PR can I ask you to hava a look here please? -- This is an automated message from the Apache Git Service. To

[PR] [FLINK-33796] Add ability to customize java version for python ci in connectors [flink-connector-shared-utils]

2023-12-11 Thread via GitHub
snuyanzin opened a new pull request, #30: URL: https://github.com/apache/flink-connector-shared-utils/pull/30 Besides adding ability to customize java version it also adds some tests for it The PR is done in a similar way it is done for non-python ci -- This is an automated message fro