Re: [PR] [FLINK-33875][runtime] Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler [flink]

2024-08-07 Thread via GitHub
1996fanrui merged PR #25134: URL: https://github.com/apache/flink/pull/25134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-33875][runtime] Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler [flink]

2024-08-06 Thread via GitHub
RocMarshal commented on PR #25134: URL: https://github.com/apache/flink/pull/25134#issuecomment-2271027729 HI, @1996fanrui Thank you very much for the quick review. I made some change based on your comments. PTAL if you had the free time~ :) -- This is an automated message from the Apache

Re: [PR] [FLINK-33875][runtime] Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler [flink]

2024-08-06 Thread via GitHub
1996fanrui commented on code in PR #25134: URL: https://github.com/apache/flink/pull/25134#discussion_r1705068636 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridgeResourceDeclarationTest.java: ## @@ -205,12 +223,36 @@ void testR

Re: [PR] [FLINK-33875][runtime] Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler [flink]

2024-08-05 Thread via GitHub
1996fanrui commented on code in PR #25134: URL: https://github.com/apache/flink/pull/25134#discussion_r1703679953 ## flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridgeResourceDeclarationTest.java: ## @@ -205,12 +224,36 @@ void testR

Re: [PR] [FLINK-33875][runtime] Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler [flink]

2024-08-02 Thread via GitHub
RocMarshal commented on PR #25134: URL: https://github.com/apache/flink/pull/25134#issuecomment-2266352507 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment