Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-28 Thread via GitHub
1996fanrui merged PR #24004: URL: https://github.com/apache/flink/pull/24004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-28 Thread via GitHub
1996fanrui merged PR #24005: URL: https://github.com/apache/flink/pull/24005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-28 Thread via GitHub
1996fanrui merged PR #23994: URL: https://github.com/apache/flink/pull/23994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-28 Thread via GitHub
1996fanrui commented on PR #24005: URL: https://github.com/apache/flink/pull/24005#issuecomment-1871024583 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-27 Thread via GitHub
flinkbot commented on PR #24005: URL: https://github.com/apache/flink/pull/24005#issuecomment-1870792748 ## CI report: * ab9a7e1dd0bd7b452962e1530cdc311af87f482d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-27 Thread via GitHub
flinkbot commented on PR #24004: URL: https://github.com/apache/flink/pull/24004#issuecomment-1870792692 ## CI report: * f6d8713420217a9e2abcaf8e29a5461b5e89f00b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-27 Thread via GitHub
1996fanrui opened a new pull request, #24005: URL: https://github.com/apache/flink/pull/24005 backporting https://github.com/apache/flink/pull/23994 to 1.17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-27 Thread via GitHub
1996fanrui opened a new pull request, #24004: URL: https://github.com/apache/flink/pull/24004 backporting https://github.com/apache/flink/pull/23994 to 1.18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-26 Thread via GitHub
RocMarshal commented on PR #23994: URL: https://github.com/apache/flink/pull/23994#issuecomment-1869917144 > It's indeed a bug. The removeConfig and removeKey of DelegatingConfiguration missed the prefix as well. I didn't notice them in the beginning. Would you like to fix it? If yes, feel

Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-26 Thread via GitHub
1996fanrui commented on PR #23994: URL: https://github.com/apache/flink/pull/23994#issuecomment-1869905090 Thanks @RocMarshal for the quick review! > if we run the followed case, will be our expected results consistent with the current fixed results? > > ``` > @Test

Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-26 Thread via GitHub
RocMarshal commented on code in PR #23994: URL: https://github.com/apache/flink/pull/23994#discussion_r1436698086 ## flink-core/src/test/java/org/apache/flink/configuration/DelegatingConfigurationTest.java: ## @@ -136,15 +136,65 @@ public void testDelegationConfigurationToMapCo

Re: [PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-26 Thread via GitHub
flinkbot commented on PR #23994: URL: https://github.com/apache/flink/pull/23994#issuecomment-1869458088 ## CI report: * 19de85716cc7962c47836d5d11859c333d4d454b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33942][configuration] Fix the bug that DelegatingConfiguration misses the prefix in some get methods [flink]

2023-12-26 Thread via GitHub
1996fanrui opened a new pull request, #23994: URL: https://github.com/apache/flink/pull/23994 ## What is the purpose of the change DelegatingConfiguration misses the perfix for some methods, such as: - DelegatingConfiguration#getInteger(org.apache.flink.configuration.ConfigOpti