Re: [PR] [FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces [flink-connector-elasticsearch]

boring-cyborg[bot] commented on PR #88: URL: https://github.com/apache/flink-connector-elasticsearch/pull/88#issuecomment-1911606536 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- T

Re: [PR] [FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces [flink-connector-elasticsearch]

Jiabao-Sun commented on code in PR #88: URL: https://github.com/apache/flink-connector-elasticsearch/pull/88#discussion_r1467341955 ## pom.xml: ## @@ -339,6 +339,13 @@ under the License. 2.1 + +

Re: [PR] [FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces [flink-connector-elasticsearch]

Jiabao-Sun commented on PR #88: URL: https://github.com/apache/flink-connector-elasticsearch/pull/88#issuecomment-1911718884 CI passes locally https://github.com/Jiabao-Sun/flink-connector-elasticsearch/actions/runs/7665812325/job/20892471652. @MartijnVisser please help take a look. Than

Re: [PR] [FLINK-34113] Update flink-connector-elasticsearch to be compatible with updated SinkV2 interfaces [flink-connector-elasticsearch]

Jiabao-Sun commented on PR #88: URL: https://github.com/apache/flink-connector-elasticsearch/pull/88#issuecomment-1912905198 > @Jiabao-Sun Thanks for this, but then we also need to make sure that this is tested against 1.19-SNAPSHOT if I'm not mistaken. Can you add that to this PR, so we c