Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-05-26 Thread via GitHub
reswqa merged PR #24634: URL: https://github.com/apache/flink/pull/24634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-05-22 Thread via GitHub
X-czh commented on PR #24634: URL: https://github.com/apache/flink/pull/24634#issuecomment-2126292943 > Thanks @X-czh, I think we only need two commits. One for the implementation and one for documentation. Thanks for the notice, @reswqa. I've rearranged the commits to have only two

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-05-22 Thread via GitHub
reswqa commented on PR #24634: URL: https://github.com/apache/flink/pull/24634#issuecomment-2126264511 Thanks @X-czh. Let's wait for the CI to pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-05-22 Thread via GitHub
reswqa commented on code in PR #24634: URL: https://github.com/apache/flink/pull/24634#discussion_r1610998637 ## docs/content/docs/dev/datastream/fault-tolerance/serialization/types_serialization.md: ## @@ -37,15 +37,16 @@ Flink places some restrictions on the type of elements

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-05-22 Thread via GitHub
X-czh commented on PR #24634: URL: https://github.com/apache/flink/pull/24634#issuecomment-2126217002 @reswqa Thanks for the review. I've rebased on latest master branch, and it has been highlighted in the doc content as follows: > Currently, only `Map`, `List` and its super interface

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-05-22 Thread via GitHub
reswqa commented on code in PR #24634: URL: https://github.com/apache/flink/pull/24634#discussion_r1610929345 ## docs/content/docs/dev/datastream/fault-tolerance/serialization/types_serialization.md: ## @@ -37,15 +37,16 @@ Flink places some restrictions on the type of elements

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-05-08 Thread via GitHub
X-czh commented on code in PR #24634: URL: https://github.com/apache/flink/pull/24634#discussion_r1593430099 ## docs/content/docs/dev/datastream/fault-tolerance/serialization/types_serialization.md: ## @@ -37,15 +37,16 @@ Flink places some restrictions on the type of elements

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-04-09 Thread via GitHub
X-czh commented on code in PR #24634: URL: https://github.com/apache/flink/pull/24634#discussion_r1557445325 ## docs/content/docs/dev/datastream/fault-tolerance/serialization/types_serialization.md: ## @@ -37,15 +37,16 @@ Flink places some restrictions on the type of elements

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-04-08 Thread via GitHub
reswqa commented on code in PR #24634: URL: https://github.com/apache/flink/pull/24634#discussion_r1556930144 ## docs/content/docs/dev/datastream/fault-tolerance/serialization/types_serialization.md: ## @@ -37,15 +37,16 @@ Flink places some restrictions on the type of elements

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-04-08 Thread via GitHub
X-czh commented on PR #24634: URL: https://github.com/apache/flink/pull/24634#issuecomment-2042856281 @reswqa Hi, could you help take a look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-04-08 Thread via GitHub
flinkbot commented on PR #24634: URL: https://github.com/apache/flink/pull/24634#issuecomment-2042769387 ## CI report: * c93a19e5bcb3657bd30bf47ceff989e19bc80a53 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34123][core][type] Introduce built-in serialization support for map and lists [flink]

2024-04-08 Thread via GitHub
X-czh opened a new pull request, #24634: URL: https://github.com/apache/flink/pull/24634 ## What is the purpose of the change Introduce built-in serialization support for map and lists, which falls back to Kyro previously. ## Brief change log Introduce built-in