Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-28 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1913822230 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-28 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1913631542 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-28 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1913572174 > @xishuaidelin The failure case is an known issue (https://issues.apache.org/jira/browse/FLINK-34206), you can rebase the latest master and rerun the tests. @lincoln-lil Tha

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-28 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1913571547 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-27 Thread via GitHub
lincoln-lil commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1913183889 @xishuaidelin The failure case is an known issue (https://issues.apache.org/jira/browse/FLINK-34206), you can rebase the latest master and rerun the tests. -- This is an automa

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-26 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1912079018 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-26 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1911877304 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-25 Thread via GitHub
xishuaidelin commented on PR #24161: URL: https://github.com/apache/flink/pull/24161#issuecomment-1911579714 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-25 Thread via GitHub
xishuaidelin commented on code in PR #24161: URL: https://github.com/apache/flink/pull/24161#discussion_r1467258035 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala: ## @@ -112,6 +112,7 @@ class

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-25 Thread via GitHub
xishuaidelin commented on code in PR #24161: URL: https://github.com/apache/flink/pull/24161#discussion_r1467257676 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/MinibatchUtil.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache S

Re: [PR] [FLINK-34222][table] End-to-end implementation of minibatch join [flink]

2024-01-25 Thread via GitHub
lsyldliu commented on code in PR #24161: URL: https://github.com/apache/flink/pull/24161#discussion_r1467198322 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalJoin.scala: ## @@ -112,6 +112,7 @@ class Stre