pnowojski closed pull request #24211: [FLINK-34252][table] Fix lastRecordTime
tracking in WatermarkAssignerOperator
URL: https://github.com/apache/flink/pull/24211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pnowojski commented on PR #24211:
URL: https://github.com/apache/flink/pull/24211#issuecomment-2168078012
I've prepared an improved version of this PR:
https://github.com/apache/flink/pull/24941
Closing this in favour the newer one.
--
This is an automated message from the Apache G
pnowojski commented on PR #24211:
URL: https://github.com/apache/flink/pull/24211#issuecomment-1960948515
> Do we know if watermarkInterval == 0 is a valid case where we are sure we
need to periodically emit WatermarkStatus? My interpretation when first reading
this code was that a zero val
dchristle commented on code in PR #24211:
URL: https://github.com/apache/flink/pull/24211#discussion_r1499603545
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java:
##
@@ -100,11 +100,14 @@ public
dchristle commented on code in PR #24211:
URL: https://github.com/apache/flink/pull/24211#discussion_r1499603545
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java:
##
@@ -100,11 +100,14 @@ public
1996fanrui commented on code in PR #24211:
URL: https://github.com/apache/flink/pull/24211#discussion_r1495910626
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java:
##
@@ -100,11 +100,14 @@ public
pnowojski commented on code in PR #24211:
URL: https://github.com/apache/flink/pull/24211#discussion_r1495762047
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java:
##
@@ -100,11 +100,14 @@ public
pnowojski commented on code in PR #24211:
URL: https://github.com/apache/flink/pull/24211#discussion_r1495762047
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java:
##
@@ -100,11 +100,14 @@ public
1996fanrui commented on code in PR #24211:
URL: https://github.com/apache/flink/pull/24211#discussion_r1495341757
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java:
##
@@ -100,11 +100,14 @@ public
pnowojski commented on code in PR #24211:
URL: https://github.com/apache/flink/pull/24211#discussion_r1494192141
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java:
##
@@ -100,11 +100,14 @@ public
flinkbot commented on PR #24211:
URL: https://github.com/apache/flink/pull/24211#issuecomment-1913851473
## CI report:
* 3b898a0c74a5dcb957ab7ab30b79dd82d01e8c0e UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
dchristle opened a new pull request, #24211:
URL: https://github.com/apache/flink/pull/24211
## What is the purpose of the change
In the current implementation, the lastRecordTime variable, which tracks the
time of the last received data element, is updated only when the
Wate
12 matches
Mail list logo
