snuyanzin merged PR #91:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
boring-cyborg[bot] commented on PR #91:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/91#issuecomment-2092439455
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
liuml07 commented on PR #91:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/91#issuecomment-2092337019
Thanks for reviewing and your approval. Could you help merge this @reta?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
reta commented on code in PR #91:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/91#discussion_r1574288489
##
flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchWriter.java:
##
@@ -161,17 +166,46 @@ pri
reta commented on code in PR #91:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/91#discussion_r1574279683
##
flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBuilderBase.java:
##
@@ -263,6 +271,4
snuyanzin commented on PR #91:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/91#issuecomment-2058403397
@liuml07 thanks for the contribution
it seems the ci failed because of `spotless`
could you please apply spotless to the PR?
--
This is an automated message f
liuml07 commented on PR #91:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/91#issuecomment-2058316069
@reta Thanks for the advice. I have updated the patch accordingly. I think
the `allowInsecure` and the `sslContextSupplier` are mutually exclusive, so I
added some vali
reta commented on PR #91:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/91#issuecomment-2012289683
@liuml07 could you please use the same configuration/API model as [1] does
for SSL support in OpenSearch? Besides just having familiar configuration, the
API is friendly t
