JingGe merged PR #24279:
URL: https://github.com/apache/flink/pull/24279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1980164212
@JingGe sure,could you help me do the "Squash and merge" action? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
JingGe commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1978735942
@lxliyou001 sure, would you like to squash your commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1968797364
@JingGe could you please merge this PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1959663357
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
Zakelly commented on code in PR #24279:
URL: https://github.com/apache/flink/pull/24279#discussion_r1497538955
##
docs/content.zh/docs/ops/debugging/flame_graphs.md:
##
@@ -25,38 +25,39 @@ specific language governing permissions and limitations
under the License.
-->
-# Flam
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1956268739
> > @Zakelly
谢谢建议，还有这个pr没合入之前，每次master变更都要merge，然后merge又要过CI，CI耗时又很长，很是麻烦，我想问问CI在跑的过程中能合入吗
>
>
如果是文档类的更改，确认不对CI造成影响的可以，committer可以合。master变更的话不用merge回你的更改分支哈，如果有更改可以继续提交commit即可
Zakelly commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1956262446
> @Zakelly
谢谢建议，还有这个pr没合入之前，每次master变更都要merge，然后merge又要过CI，CI耗时又很长，很是麻烦，我想问问CI在跑的过程中能合入吗
如果是文档类的更改，确认不对CI造成影响的可以，committer可以合。master变更的话不用merge回你的更改分支哈，如果有更改可以继续提交commit即可。如果因为有冲突合
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1956218425
@Zakelly
谢谢建议，还有这个pr没合入之前，每次master变更都要merge，然后merge又要过CI，CI耗时又很长，很是麻烦，我想问问CI在跑的过程中能合入吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Zakelly commented on code in PR #24279:
URL: https://github.com/apache/flink/pull/24279#discussion_r1497039627
##
docs/content.zh/docs/ops/debugging/flame_graphs.md:
##
@@ -27,36 +27,37 @@ under the License.
# Flame Graphs
Review Comment:
我建议就直接翻译成火焰图吧，也省去很多空格的烦恼。
```s
JingGe commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1953984465
> hi @JingGe , I have done with it, is that OK for you to merge this PR?
thanks a lot.
sure, let's wait until the CI passed
--
This is an automated message from the Apache Git Ser
JingGe commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1939874511
Could you rebase your branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1937679735
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1936962285
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1936908761
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1936858432
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1936765976
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1935962036
Hi @JingGe , thank you for your advice, it is my first time participating in
the Flink project. i have added 2 commits with your suggestion, Please review
it when you have free time, t
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1935949613
> Thanks @lxliyou001 for your contribution. I just left some comments.
Hi @JingGe , thank you for your advice, it is my first time participating in
the Flink project. i have added 2
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1935945569
Hi @JingGe , thank you for your advice, it is my first time participating in
the Flink project. i have added 2 commits with your suggestion, Please review
it when you have free time,
JingGe commented on code in PR #24279:
URL: https://github.com/apache/flink/pull/24279#discussion_r1483214554
##
docs/content.zh/docs/ops/debugging/flame_graphs.md:
##
@@ -27,36 +27,37 @@ under the License.
# Flame Graphs
-[Flame Graphs](http://www.brendangregg.com/flamegra
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1931473172
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
lxliyou001 commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1931443754
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
flinkbot commented on PR #24279:
URL: https://github.com/apache/flink/pull/24279#issuecomment-1931161930
## CI report:
* 044000baf9a560be53dfa6e8432af20ef8b07865 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
lxliyou001 opened a new pull request, #24279:
URL: https://github.com/apache/flink/pull/24279
## What is the purpose of the change
Translate Flame Graphs to Chinese
## Brief change log
The page is located at "docs/content.zh/docs/ops/debugging/flame_graphs.md"
25 matches
Mail list logo
