[PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]

2024-02-11 Thread via GitHub
zentol opened a new pull request, #24298: URL: https://github.com/apache/flink/pull/24298 The setup of the table environment in this class ran before the MiniClusterExtension was set up and beforeEach was called, causing jobs to spawn separate mini clusters. Certain tests cases try running

Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]

2024-02-11 Thread via GitHub
flinkbot commented on PR #24298: URL: https://github.com/apache/flink/pull/24298#issuecomment-1937613995 ## CI report: * e3bfaa1a29a42919548e39634cf08122e1aab8bd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]

2024-02-11 Thread via GitHub
zentol commented on PR #24298: URL: https://github.com/apache/flink/pull/24298#issuecomment-1937829068 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]

2024-02-12 Thread via GitHub
XComp commented on code in PR #24298: URL: https://github.com/apache/flink/pull/24298#discussion_r1486003318 ## flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/ProtobufSQLITCaseTest.java: ## Review Comment: Can we also fix the naming in a hotfix

Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24298: URL: https://github.com/apache/flink/pull/24298#discussion_r1486012414 ## flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/VeryBigPbProtoToRowTest.java: ## @@ -20,7 +20,7 @@ import org.apache.flink.formats.pro

Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]

2024-02-12 Thread via GitHub
zentol commented on code in PR #24298: URL: https://github.com/apache/flink/pull/24298#discussion_r1486016061 ## flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/ProtobufSQLITCaseTest.java: ## Review Comment: sure -- This is an automated mess

Re: [PR] [FLINK-34422][test] BatchTestBase uses MiniClusterExtension [flink]

2024-02-12 Thread via GitHub
zentol merged PR #24298: URL: https://github.com/apache/flink/pull/24298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache