snuyanzin commented on PR #24375:
URL: https://github.com/apache/flink/pull/24375#issuecomment-2308961960
still failing on ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
snuyanzin commented on PR #24375:
URL: https://github.com/apache/flink/pull/24375#issuecomment-2042280323
@liuyongvs the ci still fails could you please have a look here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
liuyongvs commented on code in PR #24375:
URL: https://github.com/apache/flink/pull/24375#discussion_r1537071891
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowGroupReorderRule.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licensed
snuyanzin commented on code in PR #24375:
URL: https://github.com/apache/flink/pull/24375#discussion_r1535579353
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowGroupReorderRule.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licensed
snuyanzin commented on code in PR #24375:
URL: https://github.com/apache/flink/pull/24375#discussion_r1535578497
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/WindowGroupReorderRule.java:
##
@@ -0,0 +1,192 @@
+/*
+ * Licensed
flinkbot commented on PR #24375:
URL: https://github.com/apache/flink/pull/24375#issuecomment-1960997302
## CI report:
* 197c1a1d82d3a7f09195b9d5594ae707b182a592 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
liuyongvs opened a new pull request, #24375:
URL: https://github.com/apache/flink/pull/24375
## What is the purpose of the change
The PR migrates WindowGroupReorderRule to java
it doesn't touch WindowGroupReorderRuleTest to be sure that java version
continues passing it
## V
