Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-21 Thread via GitHub
masteryhx commented on PR #24381: URL: https://github.com/apache/flink/pull/24381#issuecomment-2014287639 merged 8fac8046...77945916 into master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-21 Thread via GitHub
masteryhx closed pull request #24381: [FLINK-34516] Move CheckpointingMode to flink-core URL: https://github.com/apache/flink/pull/24381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-20 Thread via GitHub
masteryhx commented on code in PR #24381: URL: https://github.com/apache/flink/pull/24381#discussion_r1533247878 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java: ## @@ -177,20 +177,44 @@ public boolean

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-20 Thread via GitHub
Zakelly commented on code in PR #24381: URL: https://github.com/apache/flink/pull/24381#discussion_r1533244572 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java: ## @@ -177,20 +177,44 @@ public boolean

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-20 Thread via GitHub
masteryhx commented on code in PR #24381: URL: https://github.com/apache/flink/pull/24381#discussion_r1533238343 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java: ## @@ -177,20 +177,44 @@ public boolean

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-18 Thread via GitHub
Zakelly commented on code in PR #24381: URL: https://github.com/apache/flink/pull/24381#discussion_r1529761768 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java: ## @@ -177,20 +177,44 @@ public boolean

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-18 Thread via GitHub
masteryhx commented on code in PR #24381: URL: https://github.com/apache/flink/pull/24381#discussion_r1529594692 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java: ## @@ -177,20 +177,44 @@ public boolean

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-15 Thread via GitHub
Zakelly commented on PR #24381: URL: https://github.com/apache/flink/pull/24381#issuecomment-1999431941 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-15 Thread via GitHub
Zakelly commented on PR #24381: URL: https://github.com/apache/flink/pull/24381#issuecomment-1999086935 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-14 Thread via GitHub
Zakelly commented on PR #24381: URL: https://github.com/apache/flink/pull/24381#issuecomment-1997034239 Rebased for conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-13 Thread via GitHub
Zakelly commented on PR #24381: URL: https://github.com/apache/flink/pull/24381#issuecomment-1996356653 @masteryhx I have transformed to the new CheckpointMode everywhere, and rebased master. Would you please take a look? -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-13 Thread via GitHub
Zakelly commented on PR #24381: URL: https://github.com/apache/flink/pull/24381#issuecomment-1994372709 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-05 Thread via GitHub
Zakelly commented on code in PR #24381: URL: https://github.com/apache/flink/pull/24381#discussion_r1513823880 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java: ## @@ -178,7 +178,9 @@ public boolean isCheckpointingEnabled()

Re: [PR] [FLINK-34516] Move CheckpointingMode to flink-core [flink]

2024-03-05 Thread via GitHub
masteryhx commented on code in PR #24381: URL: https://github.com/apache/flink/pull/24381#discussion_r1513788931 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java: ## @@ -178,7 +178,9 @@ public boolean