gyfora merged PR #791:
URL: https://github.com/apache/flink-kubernetes-operator/pull/791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
mxm commented on PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#issuecomment-1988538289
@gyfora Nice! LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
gyfora commented on PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#issuecomment-1987310999
The new and improved / consistent logging after the rework @mateczagany @mxm
:
```
[INFO ][default/basic-checkpoint-ha-example] >>> Event | Info| CLEANUP
gyfora commented on code in PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#discussion_r1518872217
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/NativeFlinkService.java:
##
@@ -356,4 +353,32 @@ public boolean
mateczagany commented on code in PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#discussion_r1518292007
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/NativeFlinkService.java:
##
@@ -356,4 +353,32 @@ public boo
gyfora commented on PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#issuecomment-1985612180
> Added some comments, but I really like this change, I think it makes a lot
of sense to let the JMs shut down the TMs themselves in native mode.
>
> But I wonder, h
mateczagany commented on code in PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#discussion_r1517507683
##
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##
@@ -1134,4 +1141,28 @@ privat
mxm commented on code in PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#discussion_r1515949420
##
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkServiceTest.java:
##
@@ -90,14 +90,12 @@ public void
mxm commented on PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#issuecomment-1983245010
Ah, got it! That makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gyfora commented on PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#issuecomment-1983241805
> I wonder, what is the difference between scaling the deployment to zero vs
removing it? I would think both issue a SIGINT to the container. If that is the
case, there sh
gyfora commented on PR #791:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/791#issuecomment-1983022360
cc @mateczagany , I would love to hear your thoughts on this as well.
I still need to finish up some tests but any feedback is welcome
--
This is an automated mes
gyfora opened a new pull request, #791:
URL: https://github.com/apache/flink-kubernetes-operator/pull/791
## What is the purpose of the change
We recently improved the JM deployment deletion mechanism, however it seems
like task manager pod deletion can get stuck sometimes for a coupl
12 matches
Mail list logo
