lvyanquan commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2472981149
Thanks for @yuanoOo's contribution, I left some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lvyanquan commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1839804631
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/sink/OceanBaseUtils.java:
lvyanquan commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1839804631
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/sink/OceanBaseUtils.java:
lvyanquan commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1839773453
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/sink/OceanBaseDataSinkOpti
yuanoOo commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2472746734
@lvyanquan Can you take a look here in your free time.
I checked and the GitHub CI failure seems to be unrelated to this PR.
--
This is an automated message from the Apache Git Serv
github-actions[bot] commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2424303259
This pull request has been automatically marked as stale because it has not
had recent activity for 60 days. It will be closed in 30 days if no further
activity occurs.
--
yuanoOo commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2295824842
@GOODBOY008 I just resolved the conflict. Please help trigger the github
workflow again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
yuanoOo commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2268010834
@GOODBOY008 Please take a look here. Looking forward to your reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
yuanoOo commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2230080527
@GOODBOY008 After version 3.2 is released,
flink-cdc-pipeline-connector-oceanbase-3.2.0.jar will be distributed and the
dead link will be activated. I think this issue can be ignored fo
GOODBOY008 commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2230043015
@yuanoOo Please fix dead link in doc , refer :
https://github.com/apache/flink-cdc/actions/runs/9869322624/job/27277822806?pr=3360#step:4:721
--
This is an automated message from t
yuanoOo commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2172064348
@GOODBOY008 I made some changes according to your review. Please review
these changes. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the messa
yuanoOo commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1641144855
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/sink/OceanBaseMetadataApplie
yuanoOo commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1642033832
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/catalog/OceanBaseCatalogFact
yuanoOo commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1641144855
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/sink/OceanBaseMetadataApplie
yuanoOo commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1641142897
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/factory/OceanBaseDataSinkFac
GOODBOY008 commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639708043
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/factory/OceanBaseDataSink
yuanoOo commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639167796
##
docs/content/docs/connectors/pipeline-connectors/oceanbase.md:
##
@@ -0,0 +1,343 @@
+---
+title: "OceanBase"
+weight: 7
+type: docs
+aliases:
+- /connectors/pipeli
whhe commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1639119977
##
docs/content/docs/connectors/pipeline-connectors/oceanbase.md:
##
@@ -0,0 +1,343 @@
+---
+title: "OceanBase"
+weight: 7
+type: docs
+aliases:
+- /connectors/pipeline-
whhe commented on code in PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#discussion_r1637472845
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oceanbase/src/main/java/org/apache/flink/cdc/connectors/oceanbase/sink/OceanBaseEventSerializatio
yuxiqian commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2161996630
Hi @yuanoOo, thanks for your great contribution! Since @whhe is familiar
with OceanBase, do you have time to take a look?
--
This is an automated message from the Apache Git Service.
yuanoOo commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2141342325
Hello everyone, Is there anyone currently following this PR and willing to
do a code review? I will continue to follow up on it.
--
This is an automated message from the Apache Git Se
yuanoOo commented on PR #3360:
URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2128951367
Please trigger the CI again，I have removed the snapshot dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
22 matches
Mail list logo
