loserwang1024 commented on PR #3150:
URL: https://github.com/apache/flink-cdc/pull/3150#issuecomment-2033455598
@yuxiqian , thanks for your advise.
I think cast decimal to VARCHAR rather than VARCHAR/INT/BIGINT/LARGEINT is
more easy for user to understand, so I just modified it. Could
yuxiqian commented on PR #3150:
URL: https://github.com/apache/flink-cdc/pull/3150#issuecomment-2031514128
Thanks for @loserwang1024's contribution, left some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
yuxiqian commented on code in PR #3150:
URL: https://github.com/apache/flink-cdc/pull/3150#discussion_r1547462148
##
yuxiqian commented on code in PR #3150:
URL: https://github.com/apache/flink-cdc/pull/3150#discussion_r1547451624
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksUtils.java:
yuxiqian commented on code in PR #3150:
URL: https://github.com/apache/flink-cdc/pull/3150#discussion_r1547445765
##
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksUtils.java:
loserwang1024 commented on code in PR #3150:
URL: https://github.com/apache/flink-cdc/pull/3150#discussion_r1526000193
##
fanqiejiang8 commented on code in PR #3150:
URL: https://github.com/apache/flink-cdc/pull/3150#discussion_r1525911725
##
loserwang1024 commented on PR #3150:
URL: https://github.com/apache/flink-cdc/pull/3150#issuecomment-1999073355
@ruanhang1993 @lvyanquan @banmoy , CC, I am not so familiar with StarRocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
loserwang1024 opened a new pull request, #3150:
URL: https://github.com/apache/flink-cdc/pull/3150
### What's the problem
Flink only have bigint type, if mysql data is unsigned bigint , maybe out of
range, so cast to DECIMAL(20, 0).
If starrocks supports unsigned bigint, maybe can
