Re: [PR] [FLINK-34731][runtime] Remove SpeculativeScheduler and incorporate its features into AdaptiveBatchScheduler. [flink]

2024-03-21 Thread via GitHub
zhuzhurk closed pull request #24524: [FLINK-34731][runtime] Remove SpeculativeScheduler and incorporate its features into AdaptiveBatchScheduler. URL: https://github.com/apache/flink/pull/24524 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-34731][runtime] Remove SpeculativeScheduler and incorporate its features into AdaptiveBatchScheduler. [flink]

2024-03-21 Thread via GitHub
zhuzhurk commented on code in PR #24524: URL: https://github.com/apache/flink/pull/24524#discussion_r1533719880 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -232,8 +230,8 @@ protected void

Re: [PR] [FLINK-34731][runtime] Remove SpeculativeScheduler and incorporate its features into AdaptiveBatchScheduler. [flink]

2024-03-21 Thread via GitHub
JunRuiLee commented on PR #24524: URL: https://github.com/apache/flink/pull/24524#issuecomment-2011980990 Thanks @zhuzhurk for the review, I've updated this pr, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-34731][runtime] Remove SpeculativeScheduler and incorporate its features into AdaptiveBatchScheduler. [flink]

2024-03-21 Thread via GitHub
JunRuiLee commented on code in PR #24524: URL: https://github.com/apache/flink/pull/24524#discussion_r1533688677 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultSpeculativeExecutionHandler.java: ## @@ -7,62 +7,37 @@ * "License"); you may

Re: [PR] [FLINK-34731][runtime] Remove SpeculativeScheduler and incorporate its features into AdaptiveBatchScheduler. [flink]

2024-03-21 Thread via GitHub
zhuzhurk commented on code in PR #24524: URL: https://github.com/apache/flink/pull/24524#discussion_r1533349277 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java: ## @@ -183,21 +193,59 @@ public AdaptiveBatchScheduler(

Re: [PR] [FLINK-34731][runtime] Remove SpeculativeScheduler and incorporate its features into AdaptiveBatchScheduler. [flink]

2024-03-21 Thread via GitHub
zhuzhurk commented on code in PR #24524: URL: https://github.com/apache/flink/pull/24524#discussion_r1533346303 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerBuilder.java: ## @@ -322,39 +321,14 @@ public DefaultScheduler build() throws