1996fanrui merged PR #801:
URL: https://github.com/apache/flink-kubernetes-operator/pull/801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
1996fanrui commented on PR #801:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/801#issuecomment-2058446456
Hi @mxm , I merge this PR first, feel free to ping me if you have any
comment in the future, thanks~
--
This is an automated message from the Apache Git Service.
To
gyfora commented on PR #801:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/801#issuecomment-2024422087
sounds good @1996fanrui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
1996fanrui commented on PR #801:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/801#issuecomment-2024295706
> Thanks Rui! The changes make sense to me. To Gyulas point, I think we
should try to deduplicate the logic such that both Kubernetes autoscaler and
standalone use the
mxm commented on PR #801:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/801#issuecomment-2022693008
Thanks Rui! The changes make sense to me. To Gyulas point, I think we should
try to deduplicate the logic such that both Kubernetes autoscaler and
standalone use the same cod
1996fanrui commented on PR #801:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/801#issuecomment-2017164952
Thanks @mxm for the review and discussion!
> > This issue only affects the standalone autoscaler as the kubernetes
operator has this logic already in place for s
1996fanrui commented on code in PR #801:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/801#discussion_r1535104524
##
flink-autoscaler-standalone/src/test/java/org/apache/flink/autoscaler/standalone/flinkcluster/FlinkClusterJobListFetcherTest.java:
##
@@ -231,6 +
1996fanrui commented on PR #801:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/801#issuecomment-2011833091
> This issue only affects the standalone autoscaler as the kubernetes
operator has this logic already in place for setting the RUNNING state. Can we
somehow deduplicat
gyfora commented on PR #801:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/801#issuecomment-2011816958
This issue only affects the standalone autoscaler as the kubernetes operator
has this logic already in place for setting the RUNNING state. Can we somehow
deduplicate this
1996fanrui opened a new pull request, #801:
URL: https://github.com/apache/flink-kubernetes-operator/pull/801
## What is the purpose of the change
Currently, the autoscaler will scale a job when the JobStatus is RUNNING.
But the JobStatus will be RUNNING once job starts schedule, so i
10 matches
Mail list logo
