reswqa merged PR #24932:
URL: https://github.com/apache/flink/pull/24932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reswqa commented on PR #24932:
URL: https://github.com/apache/flink/pull/24932#issuecomment-2168431495
I didn't review every detail since @LadyForest has already carefully
reviewed this, but this basically looks good to me.
--
This is an automated message from the Apache Git Service.
To
liyubin117 commented on PR #24932:
URL: https://github.com/apache/flink/pull/24932#issuecomment-2168329905
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
liyubin117 commented on PR #24932:
URL: https://github.com/apache/flink/pull/24932#issuecomment-2168280767
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
liyubin117 commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639976276
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java:
##
@@ -59,6 +59,10 @@ public Optional getComment() {
liyubin117 commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639976003
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogChange.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software
LadyForest commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639931090
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogChange.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software
liyubin117 commented on PR #24932:
URL: https://github.com/apache/flink/pull/24932#issuecomment-2167543287
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
liyubin117 commented on PR #24932:
URL: https://github.com/apache/flink/pull/24932#issuecomment-2167394872
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
liyubin117 commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639333418
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterCatalogComment.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache
liyubin117 commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639333058
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java:
##
@@ -48,18 +51,29 @@ public Configuration
liyubin117 commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639333766
##
flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl:
##
@@ -176,6 +176,15 @@ SqlAlterCatalog SqlAlterCatalog() :
liyubin117 commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639333418
##
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlAlterCatalogComment.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache
liyubin117 commented on code in PR #24932:
URL: https://github.com/apache/flink/pull/24932#discussion_r1639332192
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogDescriptor.java:
##
@@ -48,18 +51,29 @@ public Configuration
14 matches
Mail list logo
