fredia merged PR #24644:
URL: https://github.com/apache/flink/pull/24644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Zakelly commented on code in PR #24644:
URL: https://github.com/apache/flink/pull/24644#discussion_r1568486250
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##
@@ -349,6
fredia commented on code in PR #24644:
URL: https://github.com/apache/flink/pull/24644#discussion_r1566649212
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##
@@ -349,6
Zakelly commented on PR #24644:
URL: https://github.com/apache/flink/pull/24644#issuecomment-2058127691
> Thanks for this pr! Overall, LGTM. I have one question:
>
> If a subtask completes its checkpoint but the job's overall checkpoint
fails, the FileMergingSnapshotManager will
Zakelly commented on code in PR #24644:
URL: https://github.com/apache/flink/pull/24644#discussion_r1566633317
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##
@@ -349,6
ljz2051 commented on code in PR #24644:
URL: https://github.com/apache/flink/pull/24644#discussion_r1562362549
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##
@@ -70,6 +72,9 @@ public abstract class
fredia commented on code in PR #24644:
URL: https://github.com/apache/flink/pull/24644#discussion_r1565310108
##
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java:
##
@@ -349,6
Zakelly commented on code in PR #24644:
URL: https://github.com/apache/flink/pull/24644#discussion_r1565161944
##
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##
@@ -459,13 +470,28 @@ public void
Zakelly commented on PR #24644:
URL: https://github.com/apache/flink/pull/24644#issuecomment-2048883029
@ljz2051 @fredia Would you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
flinkbot commented on PR #24644:
URL: https://github.com/apache/flink/pull/24644#issuecomment-2045072093
## CI report:
* be934f9e818e19f1511933f82034918a68618a29 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Zakelly opened a new pull request, #24644:
URL: https://github.com/apache/flink/pull/24644
## What is the purpose of the change
This is a sub-task of FLIP-306. The life-cycle maintenance of underlying
files in file merging manager needs the info of state handle reusing. This PR
11 matches
Mail list logo
