Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-12 Thread via GitHub
reswqa closed pull request #24725: [FLINK-34977][API] Introduce State Access on DataStream API V2 URL: https://github.com/apache/flink/pull/24725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-12 Thread via GitHub
jeyhunkarimov commented on PR #24725: URL: https://github.com/apache/flink/pull/24725#issuecomment-2163282560 Thanks a lot @reswqa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-12 Thread via GitHub
jeyhunkarimov commented on PR #24725: URL: https://github.com/apache/flink/pull/24725#issuecomment-2162579459 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-09 Thread via GitHub
jeyhunkarimov commented on PR #24725: URL: https://github.com/apache/flink/pull/24725#issuecomment-2156736006 Hi @reswqa thanks a lot for the review. Could you please do another pass in your available time? Thanks! -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-07 Thread via GitHub
jeyhunkarimov commented on code in PR #24725: URL: https://github.com/apache/flink/pull/24725#discussion_r1631634734 ## flink-datastream/src/main/java/org/apache/flink/datastream/impl/context/DefaultStateManager.java: ## @@ -49,6 +80,82 @@ public K getCurrentKey() { re

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-07 Thread via GitHub
jeyhunkarimov commented on code in PR #24725: URL: https://github.com/apache/flink/pull/24725#discussion_r1631491625 ## flink-core-api/src/main/java/org/apache/flink/api/common/typeinfo/TypeDescriptors.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-34977][API] Introduce State Access on DataStream API V2 [flink]

2024-06-06 Thread via GitHub
reswqa commented on code in PR #24725: URL: https://github.com/apache/flink/pull/24725#discussion_r1630562709 ## flink-datastream/src/test/java/org/apache/flink/datastream/impl/common/BasicTypeDescriptorTest.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Found