[PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-15 Thread via GitHub
zhongqishang opened a new pull request, #3226: URL: https://github.com/apache/flink-cdc/pull/3226 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-07-16 Thread via GitHub
github-actions[bot] commented on PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#issuecomment-2232036888 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-16 Thread via GitHub
zhongqishang commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1566843014 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-values/src/test/java/org/apache/flink/cdc/connectors/values/source/ValuesDataSourceITCase

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-19 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1571940092 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-values/src/test/java/org/apache/flink/cdc/connectors/values/source/ValuesDataSourceITCase.jav

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-19 Thread via GitHub
zhongqishang commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1572098665 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-values/src/test/java/org/apache/flink/cdc/connectors/values/source/ValuesDataSourceITCase

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun commented on PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#issuecomment-2078993303 Thanks @zhongqishang for this fix. Hi @yuxiqian, do you have time to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#issuecomment-2079004056 @Jiabao-Sun Sure, I'll take it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1580840112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent deseri

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1580840112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent deseri

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1580840112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent deseri

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
zhongqishang commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1581741205 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent de