Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun merged PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-13 Thread via GitHub
Jiabao-Sun commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1639108698 ## flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/definition/PipelineValidationTest.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1636001422 ##

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635999340 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/test/java/org/apache/flink/cdc/connectors/kafka/sink/KafkaDataSinkFactoryTest.java:

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
yuxiqian commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635956703 ## flink-cdc-common/src/test/java/org/apache/flink/cdc/common/factories/FactoryHelperTests.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-35121][common] Adds validation for pipeline definition options [flink-cdc]

2024-06-12 Thread via GitHub
morazow commented on code in PR #3382: URL: https://github.com/apache/flink-cdc/pull/3382#discussion_r1635924042 ## flink-cdc-common/src/test/java/org/apache/flink/cdc/common/factories/FactoryHelperTests.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software