1996fanrui merged PR #24944:
URL: https://github.com/apache/flink/pull/24944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.ap
1996fanrui merged PR #24943:
URL: https://github.com/apache/flink/pull/24943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.ap
1996fanrui merged PR #24942:
URL: https://github.com/apache/flink/pull/24942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.ap
flinkbot commented on PR #24944:
URL: https://github.com/apache/flink/pull/24944#issuecomment-2171040780
## CI report:
* d5818ed937108ff91ad69bb8120659f7f8477c56 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
elon-X opened a new pull request, #24944:
URL: https://github.com/apache/flink/pull/24944
[FLINK-35157][runtime] Sources with watermark alignment get stuck once some
subtasks finish
## What is the purpose of the change
*(For example: This pull request makes task deploym
flinkbot commented on PR #24943:
URL: https://github.com/apache/flink/pull/24943#issuecomment-2171039260
## CI report:
* 52f30d7931f6da3605e813e0824613381bf9cedf UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
elon-X opened a new pull request, #24943:
URL: https://github.com/apache/flink/pull/24943
[FLINK-35157][runtime] Sources with watermark alignment get stuck once some
subtasks finish
## What is the purpose of the change
*(For example: This pull request makes task deploym
flinkbot commented on PR #24942:
URL: https://github.com/apache/flink/pull/24942#issuecomment-2171037635
## CI report:
* 8899d14ad618b510d4ce73ed4306ff1ce909a87d UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
1996fanrui merged PR #24757:
URL: https://github.com/apache/flink/pull/24757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.ap
1996fanrui commented on PR #24757:
URL: https://github.com/apache/flink/pull/24757#issuecomment-2164660806
@elon-X The CI fails, could you rebase the master branch first? We can
follow the CI after rebaseing.
--
This is an automated message from the Apache Git Service.
To respond to the m
elon-X commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1637436928
##
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java:
##
@@ -310,6 +310,53 @@ void testWatermarkAggregatorRando
1996fanrui commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1637386871
##
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java:
##
@@ -310,6 +310,53 @@ void testWatermarkAggregatorR
elon-X commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1636303927
##
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java:
##
@@ -310,6 +310,53 @@ void testWatermarkAggregatorRando
1996fanrui commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1626888044
##
flink-tests/src/test/java/org/apache/flink/test/streaming/api/datastream/WatermarkAlignmentITCase.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Softwar
elon-X commented on PR #24757:
URL: https://github.com/apache/flink/pull/24757#issuecomment-2148906495
@1996fanrui I've made some changes based on your suggestions. Please review
the changes when you have a chance and let me know if there are any further
improvements needed. Thanks!
--
T
1996fanrui commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1625296576
##
flink-tests/src/test/java/org/apache/flink/test/streaming/api/datastream/SubTaskFinishedWithWatermarkAlignmentITCase.java:
##
@@ -0,0 +1,52 @@
+package org.apache
elon-X commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1624644653
##
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##
@@ -201,8 +201,11 @@ void announceCombinedWatermark() {
//
1996fanrui commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1612651502
##
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##
@@ -201,8 +201,11 @@ void announceCombinedWatermark() {
1996fanrui commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1612639848
##
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##
@@ -201,8 +201,11 @@ void announceCombinedWatermark() {
elon-X commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1598735613
##
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##
@@ -201,8 +201,11 @@ void announceCombinedWatermark() {
//
1996fanrui commented on code in PR #24757:
URL: https://github.com/apache/flink/pull/24757#discussion_r1596434203
##
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java:
##
@@ -201,8 +201,11 @@ void announceCombinedWatermark() {
elon-X commented on PR #24757:
URL: https://github.com/apache/flink/pull/24757#issuecomment-2097307406
hi, @1996fanrui would you mind reviewing this for me when you have a
moment? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message,
flinkbot commented on PR #24757:
URL: https://github.com/apache/flink/pull/24757#issuecomment-2096232417
## CI report:
* 4816da1dbcd97f151bed288a8140c199f674c1c9 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
elon-X opened a new pull request, #24757:
URL: https://github.com/apache/flink/pull/24757
## What is the purpose of the change
Sources with watermark alignment get stuck once some subtasks finish, this
PR solves this problem.
## Brief change log
while some subtas
24 matches
Mail list logo