rovboyko opened a new pull request, #24703:
URL: https://github.com/apache/flink/pull/24703
## What is the purpose of the change
This change fixes the possible error because of hash collision in
MiniBatchStreamingJoinOperator
## Brief change log
Currently for
xishuaidelin commented on PR #24703:
URL: https://github.com/apache/flink/pull/24703#issuecomment-2082060777
LGTM! @lsyldliu do you have any more comments on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lsyldliu closed pull request #24703: [FLINK-35184][table-runtime] fix minibatch
join hash collision
URL: https://github.com/apache/flink/pull/24703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
flinkbot commented on PR #24703:
URL: https://github.com/apache/flink/pull/24703#issuecomment-2071586145
## CI report:
* f175f51241b20866bfa6b9e74dba9ba05ec7c918 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
xishuaidelin commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1575842429
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/bundle/InputSideHasNoUniqueKeyBundle.java:
##
@@ -96,15 +96,1
rovboyko commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1575883259
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/bundle/InputSideHasNoUniqueKeyBundle.java:
##
@@ -96,15 +96,19 @@
xishuaidelin commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1575919885
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/bundle/InputSideHasNoUniqueKeyBundle.java:
##
@@ -96,15 +96,1
xishuaidelin commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1575973786
##
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java:
##
@@ -849,6 +851,46
xishuaidelin commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1575985361
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/bundle/InputSideHasNoUniqueKeyBundle.java:
##
@@ -96,15 +96,1
xishuaidelin commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1575991126
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/bundle/InputSideHasNoUniqueKeyBundle.java:
##
@@ -96,15 +96,1
rovboyko commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1577344921
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/bundle/InputSideHasNoUniqueKeyBundle.java:
##
@@ -96,15 +96,19 @@
rovboyko commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1577347776
##
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java:
##
@@ -849,6 +851,46 @@
rovboyko commented on PR #24703:
URL: https://github.com/apache/flink/pull/24703#issuecomment-2078558651
Hi @xishuaidelin !
I've fixed all places you noticed about. Could you please review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
xishuaidelin commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1581998200
##
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java:
##
@@ -1953,4 +1947,
xishuaidelin commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1581998200
##
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java:
##
@@ -1953,4 +1947,
rovboyko commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1582032156
##
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java:
##
@@ -1953,4 +1947,61 @
16 matches
Mail list logo