StefanRRichter merged PR #24722:
URL: https://github.com/apache/flink/pull/24722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flin
rkhachatryan commented on PR #24722:
URL: https://github.com/apache/flink/pull/24722#issuecomment-2083081066
Thanks for updating the PR, LGTM
(please re-format the code and commit history before merging)
--
This is an automated message from the Apache Git Service.
To respond to the mess
StefanRRichter commented on PR #24722:
URL: https://github.com/apache/flink/pull/24722#issuecomment-2078937897
Thanks for the review, for
1. I don't know how we can test this without OS level tools, but I'm open to
ideas.
2. I don't think `GSRecoverableFsDataOutputStream` requires any
rkhachatryan commented on PR #24722:
URL: https://github.com/apache/flink/pull/24722#issuecomment-2078909771
Thanks for the fix, I think it should solve the problem. However,
1. Is there a way to test it?
2. Should `GSRecoverableFsDataOutputStream` and `FSDataOutputStreamWrapper`
also
flinkbot commented on PR #24722:
URL: https://github.com/apache/flink/pull/24722#issuecomment-2077228887
## CI report:
* 9cd6ad61e5ad7bdc825c9bb634a067747cb4b84a UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
StefanRRichter opened a new pull request, #24722:
URL: https://github.com/apache/flink/pull/24722
## What is the purpose of the change
Sync'ing back written data to disk is seemingly missing from some
implementation of RecoverableFsDataOutputStream. This PR adds sync, typically
by ca