boring-cyborg[bot] commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2128322457
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
luoyuxia merged PR #18:
URL: https://github.com/apache/flink-connector-hive/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
WencongLiu commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2126952619
It seems that the test is canceled. Could you help me trigger it again？
@luoyuxia
--
This is an automated message from the Apache Git Service.
To respond to the message,
WencongLiu commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2126933902
@luoyuxia I've updated the pull request. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1611568586
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,223 @@
luoyuxia commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2120403078
> Thanks for the update, +1 for merging.
>
> It seems that the CI failure is unrelated, @luoyuxia could you please help
confirming this?
Yeah. I think the CI
luoyuxia commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1594867337
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/parse/HiveASTParser.g:
##
@@ -721,6 +722,12 @@ import
luoyuxia commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1594867337
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/parse/HiveASTParser.g:
##
@@ -721,6 +722,12 @@ import
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1606184817
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserConstants.java:
##
@@ -30,4 +30,6 @@ public class
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1606184637
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,230 @@
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1606184227
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,230 @@
WencongLiu commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1606183796
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,230 @@
reswqa commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1602581492
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserConstants.java:
##
@@ -30,4 +30,6 @@ public class
reswqa commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1602576000
##
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserConstants.java:
##
@@ -30,4 +30,6 @@ public class
reswqa commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1602571412
##
flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectSupportSQL11ReservedKeywordAsIdentifierTest.java:
##
@@ -0,0 +1,230 @@
+/*
+
WencongLiu closed pull request #24710: [FLINK-35221][hive] Support SQL 2011
reserved keywords as identifiers in HiveParser
URL: https://github.com/apache/flink/pull/24710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
WencongLiu opened a new pull request, #18:
URL: https://github.com/apache/flink-connector-hive/pull/18
## What is the purpose of the change
According to Hive user documentation[1], starting from version 0.13.0, Hive
prohibits the use of reserved keywords as identifiers. Moreover,
boring-cyborg[bot] commented on PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#issuecomment-2081434598
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is
flinkbot commented on PR #24710:
URL: https://github.com/apache/flink/pull/24710#issuecomment-2074575051
## CI report:
* 35c5aa0e07345d600144395260967b20ecbca830 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
WencongLiu opened a new pull request, #24710:
URL: https://github.com/apache/flink/pull/24710
## What is the purpose of the change
According to Hive user documentation[1], starting from version 0.13.0, Hive
prohibits the use of reserved keywords as identifiers. Moreover, versions
20 matches
Mail list logo
