Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-29 Thread via GitHub
boring-cyborg[bot] commented on PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#issuecomment-2083840330 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-29 Thread via GitHub
mas-chen merged PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-29 Thread via GitHub
IgnasD commented on code in PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1582739755 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java: ## @@ -464,6 +466,87

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-27 Thread via GitHub
mas-chen commented on code in PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1581993642 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java: ## @@ -464,6

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-27 Thread via GitHub
mas-chen commented on code in PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1581993642 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java: ## @@ -464,6

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-27 Thread via GitHub
mas-chen commented on PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#issuecomment-2081161614 Rerunning CI--seems to be flaky behavior in IT tests: ``` 2024-04-27T19:26:47.5915234Z 19:26:47,500 [Flat Map (1/1)#0] WARN

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-27 Thread via GitHub
IgnasD commented on code in PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1581844568 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java: ## @@ -464,6 +466,87

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-26 Thread via GitHub
mas-chen commented on code in PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1581372979 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java: ## @@ -464,6

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-26 Thread via GitHub
IgnasD commented on PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#issuecomment-2079488271 Changed the title as requested. Also, I've added filtering to `unassignedInitialPartitions` as suggested and covered it with a test case. -- This is an automated message from