liuml07 opened a new pull request, #100: URL: https://github.com/apache/flink-connector-elasticsearch/pull/100
https://issues.apache.org/jira/browse/FLINK-35287 > In [FLINK-26088](https://issues.apache.org/jira/browse/FLINK-26088) we added support for ElasticSearch 8.0. It is based on Async sink API and does not use the base module flink-connector-elasticsearch-base. Regarding the config options (host, username, password, headers, ssl...), we pass all options from the builder to AsyncSink, and last to AsyncWriter. It is less flexible when we add new options and the constructors will get longer and multiple places may validate options unnecessarily. I think it's nice if we make the sink builder builds the NetworkConfig once, and pass it all the way to the writer. This is also how the base module for 6.x / 7.x is implemented. In my recent work adding new options to the network config, this way works simpler. I'll port that work to 8.x 1. builder builds `NetworkConfig` and pass that into sink and writer, instead of all specific config options 1. other small fixes in the builder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
